Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None.
This fixes a behavior test failure on B2: https://github.com/apache/opendal/actions/runs/43499599299/job/132157281956
Rationale for this change
WriteBehavior_OptionsLargerThanStackBuffer_RoundTripAsyncwrites a content type of about 1 KB to push the options past the 512-byte stack buffer. It ran on every service that declareswrite_with_content_type, and B2 rejects a content type that long:The capability says a service accepts a content type, not how long it may be.
The test covers the binding's fallback to native memory, which does not depend on the service.
What changes are included in this PR?
Run the test on
memoryonly, likeWriteBehavior_ConcurrentWrites_KeepEachCallsOptionsAsync.Are there any user-facing changes?
None.
Breaking changes
None.
AI Usage Statement
OPENDAL_TEST=memory dotnet test(126 passed). Not run against B2.